fix: headers already sent errors

controllers/handlers/apiErrorsHandler.js

@@ -21,15 +21,13 @@ module.exports = (error, req, res, next) => {
     ? error.statusCode
     : 500
 
-  res.status(statusCode)
-
   const description = (isClientError || isServerError)
     ? error.message
     : 'An unexpected error occurred. Try again?'
 
   if (description) {
-    return res.json({ success: false, description })
+    return res.status(statusCode).json({ success: false, description })
   } else {
-    return res.end()
+    return res.status(statusCode).end()
   }
 }

lolisafe.js

@@ -254,14 +254,18 @@ safe.use('/api', api)
 
     // Error pages
     safe.use((req, res, next) => {
-      res.setHeader('Cache-Control', 'no-store')
-      res.status(404).sendFile(path.join(paths.errorRoot, config.errorPages[404]))
+      if (!res.headersSent) {
+        res.setHeader('Cache-Control', 'no-store')
+        res.status(404).sendFile(path.join(paths.errorRoot, config.errorPages[404]))
+      }
     })
 
     safe.use((error, req, res, next) => {
       logger.error(error)
-      res.setHeader('Cache-Control', 'no-store')
-      res.status(500).sendFile(path.join(paths.errorRoot, config.errorPages[500]))
+      if (!res.headersSent) {
+        res.setHeader('Cache-Control', 'no-store')
+        res.status(500).sendFile(path.join(paths.errorRoot, config.errorPages[500]))
+      }
     })
 
     // Git hash